Skip to content

Update dlpack to v1.2 #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update dlpack to v1.2 #2193

wants to merge 4 commits into from
+389 −84

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Nov 19, 2025 •
edited
Loading

This PR proposes updating the vendored DLPack header dlpack.h to v1.2 and adds data type code and device type enum definitions where necessary

It does not work towards supporting the new C functions to optimize speed of exchange, which could be done in a follow-up PR

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

View rendered docs @ https://intelpython.github.io/dpctl/pulls/2193/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 20, 2025

Coverage Status

coverage: 86.283% (+0.007%) from 86.276%
when pulling 68c2167 on update-dlpack-v1.2
into 70920d3 on master.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_26 ran successfully.
Passed: 1110
Failed: 48
Skipped: 82

antonwolfy
antonwolfy reviewed Nov 21, 2025
View reviewed changes
dpctl/tensor/_dlpack.pyx
kDLWebGPU
kDLHexagon
kDLMAIA
kDLTrn
Copy link
Collaborator

@antonwolfy antonwolfy Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we need to update numpy_to_dlpack_versioned_capsule at line following dlpack changes added in v1.2
NumPy did that here.

Copy link
Collaborator Author

@ndgrigorian ndgrigorian Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I didn't think we would need to make a change for that part, but I'll adjust it

Copy link
Collaborator Author

@ndgrigorian ndgrigorian Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all logic should now be updated

shape and strides are both set to NULL for ndim == 0 only, and conversely, when converting from dlpack, shape and strides are simplified a bit if NULL is provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy